Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaffolding for QUIC proxy peering #47216

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Scaffolding for QUIC proxy peering #47216

wants to merge 3 commits into from
+575 −266

Conversation

espadolini
Copy link
Contributor

This PR adds some scaffolding necessary to support QUIC proxy peering:

  • the current (gRPC) peering server is tweaked so that the way it handles its TLS config is streamlined and will match what we will do for the QUIC server;
  • the client is made generic over the specific per-proxy implementation of the dialing process, with the existing implementation tweaked to fit in the interface;
  • the proxy initialization is changed to (pretend to) set up the appropriate PacketConn and a QUIC transport (to be used for both the client and the server) and start/stop/shutdown a mock QUIC peering server.

@espadolini espadolini added the no-changelog Indicates that a PR does not require a changelog entry label Oct 4, 2024
@espadolini
Copy link
Contributor Author

Each commit should be reviewable in isolation, with the changes to the existing proxy peering client being the most extensive.

rosstimothy
rosstimothy approved these changes Oct 4, 2024
View reviewed changes
lib/proxy/peer/quicserver.go
"github.com/gravitational/teleport"
)

type QUICServerConfig struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing docs

lib/proxy/peer/quicserver.go
// QUICServer is a proxy peering server that uses the QUIC protocol.
type QUICServer struct{}

func NewQUICServer(cfg QUICServerConfig) (*QUICServer, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing docs

lib/proxy/peer/server.go
@@ -95,13 +94,14 @@ func (c *ServerConfig) checkAndSetDefaults() error {

// Server is a proxy service server using grpc and tls.
type Server struct {
config ServerConfig
server *grpc.Server
log logrus.FieldLogger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we slog 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosstimothy rosstimothy rosstimothy approved these changes

@doggydogworld doggydogworld Awaiting requested review from doggydogworld

@tigrato tigrato Awaiting requested review from tigrato

@fspmarshall fspmarshall Awaiting requested review from fspmarshall

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
no-changelog Indicates that a PR does not require a changelog entry size/md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@espadolini @rosstimothy